Skip to content

Add PR Preview actions #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 26, 2025
Merged

Add PR Preview actions #381

merged 15 commits into from
May 26, 2025

Conversation

mikehosmar
Copy link
Member

@mikehosmar mikehosmar commented May 22, 2025

Two options.

  • Built in Amplify preview
    • Pros:
      • Action to show when build is complete
      • Supported by AWS
    • Cons:
      • No easy way to apply to new/all branches
  • GH Action:
    • Pros:
      • When it runs is controllable in the same way any action is
      • We can add/edit features
    • Cons:
      • We need to support it
      • Original repo is stale by 2 years.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-381.d15wgalg8jexko.amplifyapp.com

@mikehosmar mikehosmar changed the title Mh/wip/preview test Preview Testing May 22, 2025
@mikehosmar mikehosmar added the preview environment Manually create preview build label May 23, 2025
Copy link

Preview branch generated at https://mh-wip-preview-test.dfy90wyu8dics.amplifyapp.com

@mikehosmar mikehosmar force-pushed the mh/wip/preview-test branch from fa5f073 to 920d085 Compare May 23, 2025 01:22
@mikehosmar
Copy link
Member Author

After @tonybaltovski's comment I adjusted the action to allow the creation of rc branches in Amplify with the built-in preview setting enabled. So this is the best of both worlds.

@mikehosmar mikehosmar changed the title Preview Testing Add PR Preview actions May 23, 2025
@mikehosmar mikehosmar marked this pull request as ready for review May 23, 2025 15:56
@mikehosmar mikehosmar merged commit 5ccbd79 into development May 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview environment Manually create preview build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants